Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Payment prefs: use relative local and ISO 8601 dates #4370

Merged
merged 1 commit into from
Sep 29, 2016

Conversation

ayumi
Copy link
Contributor

@ayumi ayumi commented Sep 29, 2016

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).

Test Plan:

  • Add moment.js which localizes time/date things

Fix #4294

Auditors: @jkup @mrose17

Test Plan:

  1. In Prefeences > Payments, see Status and look for the "Next contribution: in {n} days".
  2. In Payment history, check that contribution dates are in ISO 8601 format (YYYY-MM-DD).
  3. Also look near the bottom for "Next contribution :in {n} days".
  4. Change Browser language in General then restart browser
  5. Go to Payments, see Status and find localized "in {n} days string"

screen shot 2016-09-28 at 17 56 28

screen shot 2016-09-28 at 17 58 51

screen shot 2016-09-29 at 01 14 29

- Add [moment.js](https://github.com/moment/moment/) which localizes time/date things

Fix #4294

Auditors: @jkup @mrose17

Test Plan:
1. In Prefeences > Payments, see Status and look for the "Next contribution: in {n} days".
2. In Payment history, check that contribution dates are in ISO 8601 format (YYYY-MM-DD).
3. Also look near the bottom for "Next contribution :in {n} days".
4. Change Browser language in General then restart browser
5. Go to Payments, see Status and find localized "in {n} days string"
@mrose17
Copy link
Member

mrose17 commented Sep 29, 2016

lgtm: please commit.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants